[REMS-296] Questionnaire package#47
Merged
plarocque4 merged 6 commits intodevfrom Jan 26, 2023
Merged
Conversation
plarocque4
reviewed
Jan 25, 2023
KeeyanGhoreshi
force-pushed
the
questionnaire-package
branch
from
f1f4d4c to
d74b3c3
Compare
plarocque4
previously approved these changes
Jan 25, 2023
Contributor
plarocque4
left a comment
plarocque4
left a comment
There was a problem hiding this comment.
The code looks clean and includes everything that the old CRD did. I tested it manually with Postman and the returned bundle included everything that I expected it to.
plarocque4
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
These changes add the questionnaire package operation to the REMS Admin FHIR server, which allows DTR to actually complete its interaction when going through the whole workflow. A VSAC API key is required to operate, however, as the ValueSets must be queried.
Support for the
$questionnaire-packageoperation involves processing the questionnaires to find sub-questionnaires, the CQL supporting those sub-questionnaires, and value sets supporting that CQL, then compiling all the resources into a bundle to be sent back. Questionnaires are processed at the time they are requested by the operation.NOTE: this entire process of gathering valuesets will have to change in relation to the VSAC caching task #46
To use this, you must first set
VSAC_KEYenvironment variable (or through env.json) as your key. I would also recommend resetting/deleting your database so that it refills with the new resources available through the CDS-Library folder which is now embedded in the REMS admin.You can test the changes by running the entire environment, going through the request generator, and opening DTR. It should successfully open a questionnaire, as it receives the parameters it is expecting from the package operation.
NOTE: Currently some of the questions do not get prepopulated. This is because the elm conversion fails to find supporting libraries at conversion time, so the cql errors out when using dependent libraries. This will have to be fixed but it is not an effect of the package operation
Issue ticket number and Jira link
REMS-296
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.